Implemented WeakKeyIdDict
This is what I put together in https://github.com/JuliaLang/julia/pull/28161 (closed PR). I thought it could perhaps live here. Note that a WeakKeyIdDict might go into Base sometime in 1.x: https://github.com/JuliaLang/julia/pull/28182, but who knows when.
Codecov Report
Merging #402 into master will decrease coverage by
0.08%. The diff coverage is95.45%.
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 98.65% 98.57% -0.09%
==========================================
Files 30 31 +1
Lines 1716 1760 +44
==========================================
+ Hits 1693 1735 +42
- Misses 23 25 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/weakkeyid_dict.jl | 95.45% <95.45%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d6ee8e0...ccc7543. Read the comment docs.
Is there any interest in this? Otherwise please close.
Any news?
After the great recent interest in this PR (two people in two month! ;-), I updated it such that it passes again tests and fixed conflicts. Ready to go, as far as I'm concerned.
Thanks. This is quite useful!
Per https://github.com/JuliaCollections/DataStructures.jl/issues/479 we are not accepting new data structures til post-1.0.0
I guess a case could be made that this PR was open long before then and so should be an exception?
+1 for an exception, since I want to use this too :). Or maybe it can be it's own small package?