AbstractTrees.jl icon indicating copy to clipboard operation
AbstractTrees.jl copied to clipboard

Restore old printnode behavior for potentially large collections

Open jlumpe opened this issue 2 years ago • 2 comments

Restoring the old printnode method for potentially large collections (fAbstractArray and AbstractDict), which just prints the type.

jlumpe avatar May 27 '22 03:05 jlumpe

Codecov Report

Merging #101 (13f50d5) into master (5d3c880) will decrease coverage by 0.13%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   52.01%   51.87%   -0.14%     
==========================================
  Files           7        7              
  Lines         373      374       +1     
==========================================
  Hits          194      194              
- Misses        179      180       +1     
Impacted Files Coverage Δ
src/builtins.jl 75.00% <0.00%> (-10.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d3c880...13f50d5. Read the comment docs.

codecov-commenter avatar May 27 '22 03:05 codecov-commenter

This seems a bit aggressive, there is a huge class of cases in which this will make the display much worse...

Perhaps our real problem here is that we use print rather than some version of show, the latter of which is compact in at least some contexts.

ExpandingMan avatar Jun 01 '22 22:06 ExpandingMan