LocalCoverage.jl icon indicating copy to clipboard operation
LocalCoverage.jl copied to clipboard

Coverage for failing tests

Open briederer opened this issue 1 year ago • 5 comments

Adds a safety measure to still process .cov files even when tests are failing.

Closes #57

briederer avatar Sep 16 '24 11:09 briederer

Sorry for messing with the tests. I wanted to achieve that the tests for this package are succeeding while in general they generate_coverage still fails. Therefore it was neccessary to add the should_throw argument to test_coverage function. This checks now that the .cov files are processed correctly even if generate_coverage still fails when one or more tests are failing.

briederer avatar Sep 16 '24 11:09 briederer

@tpapp Ready for review

briederer avatar Sep 17 '24 09:09 briederer

Thanks for the review. Added a clarification comment to your question

briederer avatar Sep 19 '24 06:09 briederer

Short reminder

briederer avatar Oct 10 '24 09:10 briederer

Thanks, I appreciate the reminder. The code now looks good to me.

I am wondering if proceeding in case of an error is always desirable. Would an argument that controls this for generate_coverage make sense? The new behavior could be the default.

Can you please add a section (eg # Error handling) to the documentation of generate_coverage that explains the new behavior? Just that errors are caught and coverage is still generated.

tpapp avatar Oct 10 '24 09:10 tpapp