Morsel.jl icon indicating copy to clipboard operation
Morsel.jl copied to clipboard

Issue 38 update after running

Open yfractal opened this issue 10 years ago • 6 comments

Fix issue 38

I think when same path, eg: "test", is reinserted into the RouteTable, we should update the RouteTable with the new path.

yfractal avatar Apr 18 '15 03:04 yfractal

haven't pass the Travis CI :(


ERROR: LoadError: LoadError: LoadError: ArgumentError: invalid type for argument r in method definition for isequal at /home/travis/.julia/v0.4/Morsel/src/Routes.jl:81

https://github.com/JuliaWeb/Morsel.jl/blob/master/src/Routes.jl#L81

I haven't figured out why :( ...

yfractal avatar Apr 18 '15 03:04 yfractal

Everything is broken on 0.4 right now so could be anything

IainNZ avatar Apr 18 '15 03:04 IainNZ

@IainNZ Thank you :) !

yfractal avatar Apr 18 '15 03:04 yfractal

The Julia Tuple changes, it has new syntax.. It should be

 typealias Bar Tuple{Function, Function}

in the newest Julia.

I have tried this in older version( Version 0.4.0-dev+2204 (2014-12-19 04:53 UTC) ), and the it doesn't work...

yfractal avatar Apr 22 '15 10:04 yfractal

Hi @yfractal yes, this syntax will not work in older builds. There is no point keeping compatibility with old builds for a development branch. However, we do want packages to be compatible with 0.3. The best way of doing that is via the Compat.jl package.

https://github.com/JuliaLang/Compat.jl/pull/63

aviks avatar Apr 22 '15 10:04 aviks

@aviks Thank you! The Compact.jl is so cool!

I will try to fix these.

yfractal avatar Apr 23 '15 14:04 yfractal