fix #178

[putianyi889]

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (90ef3ce) to head (f608d1b). Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files           8        8           
  Lines        1141     1143    +2     
=======================================
+ Hits         1140     1142    +2     
  Misses          1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[putianyi889]

apparently Julia 1.6 doesn't have package extensions

[jishnub]

This should be included directly on Julia 1.6

[putianyi889]

is it possible to have dependency that depends on julia version?

[jishnub]

This should work already, see https://github.com/JuliaArrays/FillArrays.jl/blob/1788108049c6c105fd4a2ea76490930be812355a/src/FillArrays.jl#L673-L677 The test failure on v1.6 appears to be because SparseArrays on that version limits dot to arrays of numbers, which leads to an ambiguity.

[longemen3000]

@jishnub do we test for Ambiguities in FillArrays ? maybe we could check if PRs of this style don't add new ambiguities. other than that, the fix seems good to add.