ArrayInterface.jl icon indicating copy to clipboard operation
ArrayInterface.jl copied to clipboard

Mono repos much more confusing than separate repos

Open chriselrod opened this issue 3 years ago • 5 comments
trafficstars

So far, I think it'd be easier to navigate and understand ArrayInterface if everything was in a separate git repo.

E.g., what did version 0.1.0 of ArrayInterfaceOffsetArrays look like, vs what does it look like now?

Using the released version, tests fail: https://github.com/JuliaSIMD/VectorizationBase.jl/runs/6540991814?check_suite_focus=true But locally they passed on master.

I can see it was fixed in this commit: https://github.com/JuliaArrays/ArrayInterface.jl/commit/8ac6d4e7f64583c5d7f4d20ea505220b77f1be11 but where is that commit relative to the release version?

From the fact that the release fails, I can tell that

[015c0d05] ArrayInterfaceOffsetArrays v0.1.0

was from before that commit. But, maybe there is also a 0.1.1 release after this commit? How do I check?

Etc.

I think separate repos are easier.

chriselrod avatar May 22 '22 03:05 chriselrod

Seems it did already exist: https://github.com/JuliaArrays/ArrayInterface.jl/issues/10#issuecomment-1133809007

Trial/error isn't nearly as nice of a way of finding things out as just being able to look at the information.

chriselrod avatar May 22 '22 03:05 chriselrod

Seems ArrayInterface 6 restricts it to 0.1.0: https://github.com/JuliaSIMD/VectorizationBase.jl/runs/6541055845?check_suite_focus=true

chriselrod avatar May 22 '22 03:05 chriselrod

ArrayInterfaceOffsetArrays.jl needs a version bump to allow 6.

https://github.com/JuliaArrays/ArrayInterface.jl/compare/v6.0.0...master#diff-3d76c60ebb9a40cc3f7d4f22d2d21e7d86aefd9973f6f262032c3babd07ec2c6R11

ChrisRackauckas avatar May 22 '22 03:05 ChrisRackauckas

This continues to be annoying. In order to see if this change is actually okay, how do I easily look up what changed in ArrayInterfaceOffsetArrays 0.1.2? https://github.com/JuliaSIMD/LoopVectorization.jl/pull/412#discussion_r893860162 It'd be trivial if ArrayInterfaceOffsetArrays were in its own git repo.

chriselrod avatar Jun 09 '22 19:06 chriselrod

I'm hopeful some of these can eventually be fully transitioned to a proper dependency in the appropriate downstream package. But I'm personally trying to make sure we get everything to load as quickly as we can and well tested before making that effort.

Tokazama avatar Jun 10 '22 01:06 Tokazama

Fixed to extension packages, and anything static should go to https://github.com/JuliaArrays/StaticArrayInterface.jl

ChrisRackauckas avatar Feb 18 '23 11:02 ChrisRackauckas