ArrayInterface.jl icon indicating copy to clipboard operation
ArrayInterface.jl copied to clipboard

Goal: get to 100% code coverage for ArrayInterface.jl

Open DilumAluthge opened this issue 3 years ago • 11 comments

For context, here is the current code coverage:

Codecov

cc: @chriselrod

DilumAluthge avatar Jan 04 '21 10:01 DilumAluthge

What's the best way to test the parses depending on CUDA?

chriselrod avatar Jan 04 '21 11:01 chriselrod

We can use Buildkite, which provides GPU CI to packages in the Julia GPU ecosystem.

I can take care of that.

DilumAluthge avatar Jan 04 '21 11:01 DilumAluthge

@chriselrod Do you have admin permissions on this repo?

DilumAluthge avatar Jan 04 '21 11:01 DilumAluthge

Yes. Or at least, I can merge. What needs to happen?

chriselrod avatar Jan 04 '21 11:01 chriselrod

Kind of complicated. We need:

  1. Merge some YAML files into this repo. This only requires merge permission on this repo.
  2. Add some webhooks to this repo. This requires admin privileges on this repo.
  3. ~Install the BuildKite GitHub app on this repo. This requires a SciML organization owner.~ This step has already been completed.
  4. The Buildkite config. I can do this part.

DilumAluthge avatar Jan 04 '21 15:01 DilumAluthge

I'll give you temporary ownership in SciML for it.

ChrisRackauckas avatar Jan 04 '21 15:01 ChrisRackauckas

Thanks. I'll ping you on GitHub (or Slack, if Slack comes back up) when it's done.

DilumAluthge avatar Jan 04 '21 15:01 DilumAluthge

Actually I don't need temporary ownership. The GitHub app is already done.

Either @chriselrod or I needs temporary admin-ship on this repo only.

DilumAluthge avatar Jan 04 '21 15:01 DilumAluthge

Just chiming in to reassure that I will keep adding tests for code I've contributed to.

Tokazama avatar Jan 04 '21 15:01 Tokazama

Webhooks are added. @ChrisRackauckas Can you de-owner me when you get a chance?

I'll make a PR in a bit to add the BuildKite YAML to this repo, and then we should be all set.

DilumAluthge avatar Jan 04 '21 15:01 DilumAluthge

De-owned. I'll keep you and @chriselrod in the team for this repo though.

ChrisRackauckas avatar Jan 04 '21 15:01 ChrisRackauckas