DomainSets.jl icon indicating copy to clipboard operation
DomainSets.jl copied to clipboard

Roadmap for future development of DomainSets

Open daanhb opened this issue 1 year ago • 3 comments

Here are a few areas I'm thinking of to improve DomainSets. I'm linking to existing issues.

  1. Factor out the map code. It has no place in this package, and there is a lot of overlap with other packages. The main motivation originally for writing new code was to allow rectangular maps, which you need to map e.g. from 1D to 3D. At the time most existing packages assume that maps are invertible, square or both. (#92, #87)
  2. Integrate better with existing packages that define domains, in orde to reuse them. A proof of concept using package extensions is in https://github.com/daanhb/DomainSetsExtensions.jl (#149)
  3. Write documentation. Even the basic syntax for primitives is not documented. The mechanism of associating domains with canonical domains is very versatile and potentially useful if it were known how to use it (#101)
  4. Avoid type piracy. A lot has improved already, but there are some remnants of operators from Base and LinearAlgebra being overloaded simply because they look nice. This will likely take another breaking release, but it should be done. (#148, #67)
  5. Come up with a good implementation of approximate in (or approx_in), using atol and rtol arguments. It's important to get this right, since we've been so careful about distinguishing between open and closed domains as well. (#124)
  6. Implement fewer concrete domains. We've been using IntervalSets for intervals. I'm reluctant to expand the implementation of simplices and hyperfaces because other packages already do this, both better and with more focus. (#100, #142)

I've been playing with a DomainSetsCore package, but I don't think it is essential to move forward so it's not on the list.

Ideally, these improvements make DomainSets smaller and yet more functional.

daanhb avatar Feb 20 '24 11:02 daanhb

Pinging a few people, consider this for-your-information: @dlfivefifty @oschulz @aplavin @hyrodium @zsunberg @cscherrer

daanhb avatar Feb 20 '24 11:02 daanhb

Update: the first item (factoring out maps) is largely done. All map code now lives in a submodule FunctionMaps.jl, which has its own test suite and could turn into a separate package. For now, everything is backwards compatible (or so it should be) and the internal change happened in v0.7.10.

daanhb avatar Apr 02 '24 12:04 daanhb

Thanks for keeping us up to date, @daanhb !

oschulz avatar Apr 03 '24 09:04 oschulz