ApproxFun.jl icon indicating copy to clipboard operation
ApproxFun.jl copied to clipboard

Export ∆ (\increment) and ∑ (\sum) as aliases of Laplacian() and sum()

Open wsshin opened this issue 2 years ago • 3 comments

This PR exports and as aliases of Laplacian() and sum().

Note that these symbols are entered by \increment and \sum, and different from Δ (\Delta) and Σ (\Sigma) that are more commonly used as variable names. Therefore, exporting these symbols do not clutter the namespace.

This PR fixes #760. Once this PR is merged, the documentation mentioning Δ (\Delta) as an alias for Laplacian() should be updated with (\increment).

wsshin avatar Jan 20 '22 16:01 wsshin

Codecov Report

Merging #761 (2561b30) into master (fef0c7f) will increase coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
+ Coverage   30.28%   30.40%   +0.12%     
==========================================
  Files          15       15              
  Lines         809      809              
==========================================
+ Hits          245      246       +1     
+ Misses        564      563       -1     
Impacted Files Coverage Δ
src/Extras/poetry.jl 6.25% <ø> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fef0c7f...2561b30. Read the comment docs.

codecov[bot] avatar Jan 20 '22 17:01 codecov[bot]

Note this is a breaking change so you should bump the minor version

dlfivefifty avatar Jan 21 '22 14:01 dlfivefifty

The visual similarity between \sum and \Sigma would make code using both hard to read. Maybe this shouldn't be exported? Users may import this if their projects aren't likely to use both.

jishnub avatar Jul 21 '22 13:07 jishnub