Javis.jl icon indicating copy to clipboard operation
Javis.jl copied to clipboard

Added an example for entropy simulation.

Open DoktorMike opened this issue 2 years ago • 5 comments

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • [ ] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • [X] Did I make sure to only change the part of the file where I introduced a new change/feature?
  • [X] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • [ ] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • [ ] Did I properly add test dependencies to the test directory (if applicable)?
  • [X] Did I check relevant tutorials that may be affected by changes in this PR?
  • [ ] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s) Closes #492

How did you address these issues with this PR? What methods did you use?

I just made a small example and put it in a file called entropy.jl under examples. Nothing else touched.

DoktorMike avatar Sep 20 '22 13:09 DoktorMike

See https://discourse.julialang.org/t/javis-collision-detection/87398/10 for a discussion on the example and why I submitted this. :)

DoktorMike avatar Sep 20 '22 13:09 DoktorMike

Thanks for this! Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

Sov-trotter avatar Sep 20 '22 13:09 Sov-trotter

Codecov Report

Merging #493 (c54222c) into main (1e74392) will decrease coverage by 0.50%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   77.74%   77.24%   -0.51%     
==========================================
  Files          38       38              
  Lines        1991     2070      +79     
==========================================
+ Hits         1548     1599      +51     
- Misses        443      471      +28     
Impacted Files Coverage Δ
src/action_animations.jl 95.37% <0.00%> (-0.44%) :arrow_down:
src/Javis.jl 96.65% <0.00%> (-0.28%) :arrow_down:
src/Shape.jl 0.00% <0.00%> (ø)
src/backgrounds.jl 100.00% <0.00%> (ø)
src/luxor_utils.jl 100.00% <0.00%> (ø)
src/structs/JPath.jl 100.00% <0.00%> (ø)
src/util.jl 97.36% <0.00%> (+0.05%) :arrow_up:
src/structs/Frames.jl 96.72% <0.00%> (+0.05%) :arrow_up:
src/svg2luxor.jl 97.03% <0.00%> (+0.13%) :arrow_up:
src/structs/Object.jl 95.55% <0.00%> (+0.20%) :arrow_up:
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 20 '22 13:09 codecov-commenter

Thanks for this! Could you also add an animation gif to the gifs folder? https://github.com/JuliaAnimators/Javis.jl/tree/main/examples/gifs

Done.

DoktorMike avatar Sep 26 '22 13:09 DoktorMike

I activated the CI for this - will review this PR asap and see if we can get this merged. Thanks @DoktorMike - you the best! :smile:

TheCedarPrince avatar Sep 28 '22 22:09 TheCedarPrince