Javis.jl icon indicating copy to clipboard operation
Javis.jl copied to clipboard

Improving Grid Line Animations

Open TheCedarPrince opened this issue 5 years ago • 6 comments

Background

As we are finishing up the Grid lines initial PR, we are already thinking about how to improve it! This is somewhat lower priority currently but will be worked on consistently.

Additional Information

Here were some thoughts @Wikunia and I were thinking about implementing next:

  • Have a lighter grid (setline(0.5) or something) and bigger lines every 5 or so steps.
  • Have numbers and titles for the axis
  • The thing about extensibility using Val for example (see #18)

I also thought of a couple that I was exploring:

  • Arrows at the end of lines
  • Defining x and y axis limits for zero-lines

If anyone else has any thoughts, feel free to drop a comment/thought! For reference, here is what the current grid lines animation look like:

grid_animation

TheCedarPrince avatar Aug 04 '20 05:08 TheCedarPrince

When you're working on this also make sure to change the test cases slightly to have better coverage. i.e you currently test 4 animations but all use the same line_gap and line_thickness.

It might also be valuable to set the color maybe even two such that every second line is using a different color.

Wikunia avatar Aug 06 '20 13:08 Wikunia

Maybe we should use SubAction appear for this as currently I feel like there is no way to actually have a drawn grid which does not disappear after it's drawn completely.

Wikunia avatar Aug 16 '20 11:08 Wikunia

That makes sense to me @Wikunia.

Furthermore, the animation here does not actually "mean" anything. What I mean by that is that I can't draw vectors or objects in relation to the grid. I'd like to change that - see #98

TheCedarPrince avatar Aug 17 '20 19:08 TheCedarPrince

See Ole's comment here in issue 97.

TheCedarPrince avatar Sep 12 '20 16:09 TheCedarPrince

Hi! Is this project still up for grabs?

muhammadalics avatar Mar 27 '21 22:03 muhammadalics

Hey @muhammadalics - I have received your email. Let's discuss there. :)

TheCedarPrince avatar Mar 28 '21 23:03 TheCedarPrince