Javis.jl icon indicating copy to clipboard operation
Javis.jl copied to clipboard

[BUG] Format check is a bit distracting

Open Sov-trotter opened this issue 4 years ago • 2 comments
trafficstars

So there are times when I forget to run the formatter and push my commits which results in an extra "format" commit this is also not a good thing to run the CI resources on a format commit.

Is it possible to have it check formatting and automatically format if false??

Sov-trotter avatar Jul 30 '21 14:07 Sov-trotter

Unfortunately it wasn't that easy last time. I also find it quite annoying from time to time. What we could do is to ignore it until the very end and format it once directly before we merge. I think @TheCedarPrince has a way to format it on saving the file.

Wikunia avatar Jul 30 '21 14:07 Wikunia

So, to comment on this, I did once upon a time have a saving mechanism (Ole did too if I recall correctly) that would autoformat my scripts, but it also introduced unnecessary friction into my workflow. I agree with Ole - I think the best way around this is to format at the end, but I'd rather still have the format check in place as it does remind us to format at the end of the PR process.

TheCedarPrince avatar Aug 14 '21 16:08 TheCedarPrince