NearestNeighborModels.jl icon indicating copy to clipboard operation
NearestNeighborModels.jl copied to clipboard

replace DictTable with DictColumnTable

Open OkonSamuel opened this issue 2 years ago • 2 comments

DictTable are just the julia Dicts which doesn't preserve ordering. This PR replaces DictTable with DictColumnTable which preseve key ordering.

OkonSamuel avatar Jul 04 '23 23:07 OkonSamuel

@ablaom a review would be appreciated.

OkonSamuel avatar Jul 04 '23 23:07 OkonSamuel

Codecov Report

Merging #59 (4526f8e) into dev (eb29518) will decrease coverage by 0.22%. The diff coverage is 44.44%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev      #59      +/-   ##
==========================================
- Coverage   92.94%   92.73%   -0.22%     
==========================================
  Files           4        4              
  Lines         397      399       +2     
==========================================
+ Hits          369      370       +1     
- Misses         28       29       +1     
Impacted Files Coverage Δ
src/NearestNeighborModels.jl 100.00% <ø> (ø)
src/models.jl 91.17% <44.44%> (-0.41%) :arrow_down:

codecov-commenter avatar Jul 04 '23 23:07 codecov-commenter