Use repl language tag for sample

[abhro]

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.89%. Comparing base (6f46257) to head (8e45385). Report is 5 commits behind head on dev.

:exclamation: Current head 8e45385 differs from pull request most recent head ae28151. Consider uploading reports for the commit ae28151 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1107   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ablaom]

@abhro My question regarding ParallelMeans notwithstanding, are you ready for a final review?

[abhro]

Sure!

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.89%. Comparing base (e341344) to head (650ebbd). Report is 13 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1107   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ablaom]

@EssamWisam Can you please go over the proposed changes to the cheatsheet.

@abhro Can you please address the ParallelKMeans comment?

[abhro]

Hello, I think I addressed it in the original comment thread? But to reiterate, this is to support the change in docs/src/transformers.md, where I changed the predicting transformers code samples to an @example block (lines 196–209), and it loads the KMeans model from the ParallelKMeans package.

[ablaom]

... this is to support the change in docs/src/transformers.md, where I changed the predicting transformers code samples to an @example block (lines 196–209), and it loads the KMeans model from the ParallelKMeans package

Thanks for the explanation.

ParallelKMeans is not a regularly maintained package. Can we please change pkg=ParallelKMeans to pkg=NearestNeighborModels? That pkg is already in the Project and both provide KMeans.

[abhro]

Hello, @EssamWisam, thank you for the feedback! I'm working on updating the cheatsheet to make it a little more consistent. Can I ask how you generated the pdf? It would help a lot in checking the changes I'm making. Thanks again!

[abhro]

@ablaom I can't find the KMeans model in NearestNeighborsModel. I could use the one in Clustering/MLJClusteringInterface. Does that work?

[ablaom]

@ablaom I can't find the KMeans model in NearestNeighborsModel. I could use the one in Clustering/MLJClusteringInterface. Does that work?

Oops :flushed: Yes, use the MLJClusteringInterface version.

[EssamWisam]

Hello, @EssamWisam, thank you for the feedback! I'm working on updating the cheatsheet to make it a little more consistent. Can I ask how you generated the pdf? It would help a lot in checking the changes I'm making. Thanks again!

Well, the MLJ website is currently under development and (as of now only) unless you have some web development frameworks expertise, it's not straightforward to generate it.

That said, avoiding overly ong long lines, using ```julia ``` more often and avoiding overlong long sections are pretty much all the conditions needed for the cheatsheet to render nicely.

[abhro]

Alrighty! I think I've made those changes. If there's something I missed, or in some ways it could be made better, please don't hesitate to let me know! Thanks!

[EssamWisam]

Alrighty! I think I've made those changes. If there's something I missed, or in some ways it could be made better, please don't hesitate to let me know! Thanks!

Thank you for the valuable contribution, @abhro. I made some minor comments.