MLJ.jl icon indicating copy to clipboard operation
MLJ.jl copied to clipboard

Document how to add plot recipes in a new model implementation

Open ablaom opened this issue 2 years ago • 4 comments

@MilesCranmer Any chance you could add a couple of lines, maybe just pointing to your implementation as an example?

It could go somewhere here - if I don't like where you put it, no matter, I can move it.

ablaom avatar Jan 09 '24 23:01 ablaom

Sure, will do. I need to merge https://github.com/MilesCranmer/SymbolicRegression.jl/pull/277 first as this creates a custom type SRFitResult for the fitresult used by SRRegressor, so that the recipe is assigned to only the fitresults from my regressors. I think this is the "right" way to do things and once its ready I will share the example (ping me if I forget!)

Current example: https://github.com/MilesCranmer/SymbolicRegression.jl/blob/4b6a3cd44f30bfa92e2fe1e53718ca85c61df088/src/PlotRecipes.jl

MilesCranmer avatar Jan 09 '24 23:01 MilesCranmer

By the way, I think the new MLJBase version was not yet released? https://github.com/JuliaAI/MLJBase.jl/commit/193ad67a1c44cb946520fe72bee41378dae44864

MilesCranmer avatar Jan 09 '24 23:01 MilesCranmer

? https://github.com/JuliaRegistries/General/pull/98572

ablaom avatar Jan 10 '24 02:01 ablaom

Oh I see it now, thanks!

MilesCranmer avatar Jan 10 '24 03:01 MilesCranmer