time-series-autoencoder icon indicating copy to clipboard operation
time-series-autoencoder copied to clipboard

Published 20 hours ago • verified publisher icon JulesBelveze

Encoded state

Open TDominiak opened this issue 3 years ago • 3 comments

Hi,

As I understand well you create y_hist in order to perform training using teacher forcing by providing the true target value to the Decoder. As an argument to the forward Decoder function, you only pass y_hist. I cannot understand why you do not pass also the Encoded Vector as the final hidden state produced from the encoder part of the model.

Thanks

TDominiak avatar Apr 23 '21 11:04 TDominiak

Hey @TDominiak thanks for actually pointing that out, that does not seem right to me either. Tbh I haven't tried the model without the attention mechanisms! Would you like to open a PR that fixes the case or a regular decoder?? 😄 (shouldn't be too much work)

Otherwise I'll try to find some time soon !

JulesBelveze avatar Apr 23 '21 13:04 JulesBelveze

Yes, sure. after i finish analyzing the solution with attention i will take care of this bug.

TDominiak avatar Apr 26 '21 05:04 TDominiak

Hey @TDominiak just checking out if you need some help?

JulesBelveze avatar May 07 '21 07:05 JulesBelveze