juicy-ace-editor icon indicating copy to clipboard operation
juicy-ace-editor copied to clipboard

Published 20 hours ago • verified publisher icon Juicy

ES Modules

Open lastmjs opened this issue 6 years ago • 8 comments

Can we move the element to being loaded through an ES Module instead of HTML imports? I'm happy to do the work and make the PR if I can get the go-ahead

lastmjs avatar Apr 24 '18 04:04 lastmjs

@lastmjs Hi I noticed your ES6-modules work-in-progress branch https://github.com/Juicy/juicy-ace-editor/compare/ES6-modules . Was there any issue with that?

kkimdev avatar Jun 11 '18 19:06 kkimdev

Hey, you can see where that went here: https://github.com/Juicy/juicy-ace-editor/pull/41 I've handed over the reins.

lastmjs avatar Jun 12 '18 03:06 lastmjs

Oh, I see, thanks!

kkimdev avatar Jun 12 '18 03:06 kkimdev

Related -> https://github.com/ajaxorg/ace/issues/3682

rjcorwin avatar Jul 20 '18 19:07 rjcorwin

Using the es6 branch of this module with a bundler like Polymer's or Angular's I'm able to get syntax highlighting working by copying an ace build directories. This is makes for really messy looking builds but it works.

rjcorwin avatar Jul 20 '18 19:07 rjcorwin

It looks like Chrome is actually planning to remove HTML Import support soon. Pages with HTML Imports on have this console warning:

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

image

MethodGrab avatar Nov 01 '18 14:11 MethodGrab

Would appreciate an update here as I'm not sure what is the recommended way to approach the Chrome deprecation warning

simonh1000 avatar Dec 06 '18 13:12 simonh1000

Current work in progress PR: #51

warpech avatar Mar 25 '19 12:03 warpech