ESP-WiFiSettings icon indicating copy to clipboard operation
ESP-WiFiSettings copied to clipboard

Add Bahasa Indonesia to supported languages

Open mitra42 opened this issue 1 year ago • 6 comments

Added support for Bahasa Indonesia, but left it out of LANGUAGE_ALL to avoid code bloat if other languages added.

To use it, define for example LANGUAGE_EN LANGUAGE_ID to have English and Indonesian as options.

mitra42 avatar Jan 14 '25 00:01 mitra42

See Issue #46

mitra42 avatar Jan 14 '25 00:01 mitra42

Thank for contributing this file.

I'm not comfortable accepting machine translations unless someone who speaks the language well confirms the translations are correct.

And I don't really understand why any language should be left out of _ALL. If someone wants a smaller footprint, they should manually select the languages to keep.

Juerd avatar Jan 14 '25 00:01 Juerd

Fair enough - could I ask to accept the PR for now and I'll commit to getting a native speaker to check it when I'm in Indonesia in a few weeks for the field trials, and doing a supplemental PR.

I left this out of _ALL because in the README you said Note: due to storage constraints on microcontroller flash filesystems, only widely used natural languages will be included.) and I wasn't clear what you considered widely used, happy to see it included by default.

This would save me having to run off a forked repo until after the trials.

mitra42 avatar Jan 14 '25 04:01 mitra42

Hi - sorry I haven't heard from you, totally understand if you don't have time to maintain or review pull releases, but I guess that means we'll have to fork the repo or rather probably merge it into ours. Its a good library - thanks for the dev, sorry that having merged it we wont' be able to contribute back.

mitra42 avatar Jan 31 '25 00:01 mitra42

Like I said, I'm not comfortable accepting machine translations.

I should have repeated that when you asked me to accept the PR anyway.

Juerd avatar Jan 31 '25 11:01 Juerd

I've now had the language confirmed by native speakers - feel free to use, or discard, as we've peeled off a fork and made some other changes.

mitra42 avatar Feb 08 '25 06:02 mitra42