react-native-wifi-reborn icon indicating copy to clipboard operation
react-native-wifi-reborn copied to clipboard

add location permission check for getCurrentWifiSSID and reScanAndLoa…

Open JohnWilliamForcier-Spiria opened this issue 2 years ago • 1 comments

Fix : #257 , #265 , #258 and clarify #238

👏 Thanks for your contribution!

eliaslecomte avatar Sep 08 '22 07:09 eliaslecomte

This patch looks good @eliaslecomte – are there any concerns about merging?

elliottkember avatar Feb 25 '23 17:02 elliottkember

@JuanSeBestia looks good to me, can this be merged and published?

robrechtme avatar May 24 '23 12:05 robrechtme

Looks like in Android 13 you can request android.permission.NEARBY_WIFI_DEVICES instead of ACCESS_FINE_LOCATION. Would it be possible to add a check for NEARBY_WIFI_DEVICES or ACCESS_FINE_LOCATION on 13? (so we could not request ACCESS_FINE_LOCATION in 13) Thanks!

ryanstout avatar May 25 '23 19:05 ryanstout

:tada: This PR is included in version 4.7.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

JuanSeBestia avatar May 26 '23 08:05 JuanSeBestia

I squash and rename to

fix(Android): add location permission check for getCurrentWifiSSID and reScanAndLoadWifiList and change error message for clarity

because semantic commits is needed to release a new version

JuanSeBestia avatar May 26 '23 08:05 JuanSeBestia

Thanks @JuanSeBestia for merging this & doing a release 🎉.

eliaslecomte avatar May 26 '23 11:05 eliaslecomte