Jesse de Wit

Results 50 comments of Jesse de Wit

Thanks for your review @joostjager. All valid comments, I'll work on modifying those points and improve the commit structure.

I think this PR is ready to be looked at by maintainers of LND. A decision maybe you guys can make is, should I use locks to make sure TrackPayments...

@guggero Is there anything I can do to make this PR easier to review?

I went ahead and removed the hard-to-read locking in favor of a comment in the rpc mether that there could be duplicates and/or out-of-order events at the start of the...

I've added a bunch of things - itest - test for the routerrpc method - test for immediate notification of inflight payments when starting a subscription when payments are inflight...

@yyforyongyu You mentioned this: > nit: debug log is not added back🧐 I did add it back, but it's one level higher in the callstack: - [here](https://github.com/lightningnetwork/lnd/pull/6335/files#diff-9ced6590b7c4cfad60e1fa1641b602da6fe758092211f30a55b19771e4186842R759) - [and here](https://github.com/lightningnetwork/lnd/pull/6335/files#diff-9ced6590b7c4cfad60e1fa1641b602da6fe758092211f30a55b19771e4186842R786)

I think it's not my fault the Travis CI and itests are failing? Looks like travis CI needs to be updated to have go 1.19.0 And the itests are a...

Thanks for the reviews and your patience guys! You rock.

@haarts Did you find it?

> @JssDWt I've tried out your suggestion [lightning/blips#18 (comment)](https://github.com/lightning/blips/pull/18#issuecomment-1240469519) in a tacked-on commit. Ah I see, that's great. I actually didn't realize you could still split up the fee computation...