json_api_client icon indicating copy to clipboard operation
json_api_client copied to clipboard
verified publisher icon JsonApiClient

Relax faraday dependency to allow 1.3.x

Open bebbs opened this issue 5 years ago • 3 comments

👋 Hello, I noticed that this gem only allows Faraday versions < 1.2.0. That gem was recently updated to 1.3.0: https://rubygems.org/gems/faraday/versions/1.3.0

Would you be open to relaxing that requirement to allow the most recent version? The tests still pass for me locally.

bebbs avatar Feb 22 '21 11:02 bebbs

Can we remove the minor cap altogether? If we can stick with a major version cap we can avoid a lot of problem with dependency conflicts.

MarcLapierre avatar Mar 02 '21 23:03 MarcLapierre

This looks reasonable. Can you take a look at the failing test and see if it's related to the change? Thanks!

gaorlov avatar Aug 18 '21 21:08 gaorlov

I tried relaxing the faraday version requirement to '~> 1' here, and then tested with Faraday 1.8.0: https://github.com/sobakasu/json_api_client/commit/bd5a63714f7c1b01764787c0494af6d459c7c78a spec tests are failing for ruby 2.2.6 and 2.3.3. I'm having trouble compiling those ruby versions on my mac m1 so hard to debug (Both 2.2.6 and 2.3.3 are past EOL)

sobakasu avatar Oct 24 '21 22:10 sobakasu