ngx-mask icon indicating copy to clipboard operation
ngx-mask copied to clipboard

fix(directive): patterns input type (#937)

Open hv-pul opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-mask/blob/develop/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: 937

What is the new behavior?

Type is now correct

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

hv-pul avatar Oct 05 '21 15:10 hv-pul

@hv-pul Hi. Looks like the latest changes broke the whole library . Needed to revert and repeat all from scratch. Please make reverse merge from actual develop

NepipenkoIgor avatar Dec 15 '21 22:12 NepipenkoIgor

@hv-pul Hi. Please read comment in issue and also you need to. solve conflicts

NepipenkoIgor avatar Sep 11 '22 09:09 NepipenkoIgor