ngx-mask
ngx-mask copied to clipboard
fix(943): if last character of suffix same as first letter inputted d…
…o not remove
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-mask/blob/develop/CONTRIBUTING.md#commit
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
What is the current behavior?
If a suffix such as .sh is added to the mask, and the first character a user inputs(e.g. h) is the last letter of the mask(e.g. .sh) it will not allow the character(h) to be inputted.
Issue Number: 943
What is the new behavior?
If it is the first character inputted, the assumption is always that it should be added to side step includes logic. All existing unit tests currently pass.
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
Fixes the issue here: https://github.com/JsDaddy/ngx-mask/issues/943