Overwatch-Item-Tracker icon indicating copy to clipboard operation
Overwatch-Item-Tracker copied to clipboard

Published 20 hours ago • verified publisher icon Js41637

implemented translation feature

Open Shinigami92 opened this issue 8 years ago • 16 comments

next steps:

  • german locales
  • improve selection of language

Shinigami92 avatar Jan 27 '17 18:01 Shinigami92

improved language selection -> DONE

Shinigami92 avatar Jan 28 '17 10:01 Shinigami92

german translation for current event added

Shinigami92 avatar Jan 28 '17 11:01 Shinigami92

Hey thanks for this, I won't be able to merge now as we're in the process of a lot of core changes to the layout and backend. I will merge it into a branch later and make a few changes for how I would like it.

Js41637 avatar Jan 28 '17 11:01 Js41637

Ok so now I go playing a bit overwatch But can you tell me, whether you can extract the language names from an API? So I don't have to write everything manualy? Otherwise this is lot of work... but makeable

Shinigami92 avatar Jan 28 '17 11:01 Shinigami92

I'm sure you can just run it all through google translate, I won't be manually translating anything, you don't have to translate it all if you don't want too, i'm sure if someone wants it enough they can do it.

Js41637 avatar Jan 28 '17 11:01 Js41637

OK, then I will translate everything manually to german with my game if someone want france or anything else, s/he can do it :)

Shinigami92 avatar Jan 28 '17 12:01 Shinigami92

Link to issue: issue#24

Shinigami92 avatar Jan 30 '17 19:01 Shinigami92

I've started to implement French translation locally.

nduriez avatar Feb 01 '17 00:02 nduriez

I finished the French localization but i can't push my changes because this push request hasn't been merged yet

nduriez avatar Feb 01 '17 15:02 nduriez

@JigAma I have invited you to my fork. Now you can make a new branch on my fork, commit your french localization to it and the make a merge request to my master-branch in my fork I will review the changes you made and the it will be added in this pull request

Shinigami92 avatar Feb 01 '17 16:02 Shinigami92

Review french translation done

Shinigami92 avatar Feb 01 '17 20:02 Shinigami92

I will soon look at all the changes and then continue with the translation. But maybe first I will wait a bit until the master isn't rapidly updated anymore :)

Shinigami92 avatar Apr 14 '17 19:04 Shinigami92

translation from language-keys to english is working de and fr are only working for events, because the old translations were compatible. only some aren't and will fallback to english

so i will translate the other missing keys the next days and hopefully JigAma will be back and translate the french

Shinigami92 avatar Apr 17 '17 18:04 Shinigami92

Sorry that I'm working a bit slow Have currently some exams

Shinigami92 avatar Apr 26 '17 17:04 Shinigami92

I'm waiting Js to merge the branch as it is right now before making the new translation because we hadn't have news since a bit of time now and I don't want to do it if i'm not sure it will be used

nduriez avatar May 19 '17 13:05 nduriez

Yes me too I havn't any response from JS whether he want to merge this branch Currently i have translated all event items but not the regular class items (they will fallback to english) It is a huge amount of work to translate the items and there are dublicates in event and regular with the current datastructur

Shinigami92 avatar May 19 '17 15:05 Shinigami92