jr-crop icon indicating copy to clipboard operation
jr-crop copied to clipboard

changed devDependencies to dependencies

Open nexus-uw opened this issue 9 years ago • 2 comments

this allows me (and hopefully others as well) to use this plugin in conjunction with main-bower-files without having to mannually override the dependencies of this component to ensure that everything is properly pulled into the build.

Currently, I have to include the following to make my build work

{
  ...
  "overrides": {
    "jr-crop" : {
      "dependencies":{
        "ionic" : "*",
        "blueimp-canvas-to-blob":"*"
      }
    }
}

nexus-uw avatar Feb 15 '16 16:02 nexus-uw

If I have it right, main-bower-files pulls all dependencies from the bower.json files, but not the devDependencies? Blueimp and ionic are only used for the examples, therefore they are in devDependencies. You should be able to include them, and your preferred version number yourself in your own bower.json.

JrSchild avatar Feb 15 '16 16:02 JrSchild

The one other thing that main-bower-files does is ensure that dependencies of the component are loaded/listed before component itself.

nexus-uw avatar Feb 15 '16 17:02 nexus-uw