react-native-ios-charts icon indicating copy to clipboard operation
react-native-ios-charts copied to clipboard

Implement markers

Open Jpadilla1 opened this issue 8 years ago • 5 comments

Jpadilla1 avatar Feb 16 '16 15:02 Jpadilla1

@Jpadilla1 I try to integrate this smart native chart lib but failed, I ever post issue here and feeling excited that you bring it to react native.

I asked developer who say the BallonMaker be implemented in ChartMarker.swift, it's not the part of ios-charts lib, hope this important component will come soon here.

thanks for your time :)

regards.

L-Jovi avatar Mar 16 '16 04:03 L-Jovi

I did a interesting progress on it.

@L-Jovi Is your problem on stackoverflow related to BalloonMarker directly?

I think support BallonMarker at this stage would be a good way to started, I tried to work with RadarMarkerView as well, but it a different design from BalloonMarker, they started it on a new marker protocol. probably for the next version, which i didn't had a chance to try with this react-native-ios-charts.

So i basically took the BalloonMarker from this commit and added the textColor property and instantiated it on CharViewBaseExtension.swift, and add some javascript props.

const config = {
      drawMarkers: true,
      marker: {
        markerColor: 'red',
        markerTextColor: 'black',
        markerFontName: 'SomeFont'
        markerFontSize: 14,
      },
}

chart

@Jpadilla1 Any thoughts and feedbacks before i can pull request?

cesardeazevedo avatar Sep 10 '16 03:09 cesardeazevedo

Hi @cesardeazevedo that looks awesome!!! Would love a pull request :)

Jpadilla1 avatar Sep 10 '16 03:09 Jpadilla1

Cool, i'll send soon.

cesardeazevedo avatar Sep 10 '16 03:09 cesardeazevedo

@cesardeazevedo cool!

L-Jovi avatar Sep 10 '16 10:09 L-Jovi