gitbook-plugin-mermaid icon indicating copy to clipboard operation
gitbook-plugin-mermaid copied to clipboard

Published 20 hours ago • verified publisher icon JozoVilcek

fixed import file on gitbook version 3.1.1

Open LiJohnson opened this issue 8 years ago • 1 comments

LiJohnson avatar Jun 18 '16 06:06 LiJohnson

Hi, thanks for the pull request. I have 2 comments / questions to address.

First, this seems as a 2 features packed in one pull request. Can you make this solely about upgrade to support gitbook version >= 3.0.0? About double click on svg, I think this does not fit here. Is it not a completely different plugin allowing opening parts of gitbook on a new tab?

Second, is this change to how paths are resolved compatible with gitbook 2.0.0 or does it work only on 3.0.0?

JozoVilcek avatar Jun 19 '16 19:06 JozoVilcek