pioneer icon indicating copy to clipboard operation
pioneer copied to clipboard

After proposal execution remove time counter (#2466)

Open chrlschwb opened this issue 2 years ago • 4 comments

issue #2466 After proposal is executed, page state changes from "Gracing" to "Executed". Using this state variable we remove time counter after proposal execution.

chrlschwb avatar Nov 18 '22 15:11 chrlschwb

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dao ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 2:43AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 2:43AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 2:43AM (UTC)

vercel[bot] avatar Nov 18 '22 15:11 vercel[bot]

please merge https://github.com/chrlschwb/pioneer/pull/1 in here and add #2466 to description

traumschule avatar Nov 19 '22 19:11 traumschule

description: issue #2466 I have closed duplicate PR and left this one

chrlschwb avatar Nov 24 '22 00:11 chrlschwb

It could still profit from prettier.

traumschule avatar Nov 24 '22 00:11 traumschule

redeployed after updating the code from dev branch of main repo

chrlschwb avatar Dec 09 '22 14:12 chrlschwb

@chrlschwb is attempting to deploy a commit to the joystream Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 15 '22 23:12 vercel[bot]

Please fix this error (the rest is unrelated and handled in #3988)

 | /home/runner/work/pioneer/pioneer/packages/ui/src/app/pages/WorkingGroups/WorkingGroupsOpening.tsx
 |   82:23  error  React Hook "useMemo" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?  react-hooks/rules-of-hooks

traumschule avatar Dec 17 '22 02:12 traumschule

 | /home/runner/work/pioneer/pioneer/packages/ui/src/accounts/components/AccountItem/AccountItem.tsx
 |   15:10  warning  'BN_ZERO' is defined but never used  @typescript-eslint/no-unused-vars
 | 
 | /home/runner/work/pioneer/pioneer/packages/ui/src/app/pages/Settings/Settings.tsx
 |   10:10  warning  'LanguageSelect' is defined but never used  @typescript-eslint/no-unused-vars
 | 
 | /home/runner/work/pioneer/pioneer/packages/ui/src/app/pages/WorkingGroups/WorkingGroupsOpening.tsx
 |   [8](https://github.com/Joystream/pioneer/actions/runs/4019926042/jobs/6907317401#step:5:9)2:23  error  React Hook "useMemo" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?  react-hooks/rules-of-hooks
 | 
 | /home/runner/work/pioneer/pioneer/packages/ui/src/council/components/election/CandidateVote/CandidateVote.tsx
 |   10:1[9](https://github.com/Joystream/pioneer/actions/runs/4019926042/jobs/6907317401#step:5:10)  warning  'TooltipDefault' is defined but never used  @typescript-eslint/no-unused-vars
 | 
 | /home/runner/work/pioneer/pioneer/packages/ui/src/forum/types/ForumCategoryWithDetails.ts
 |   3:63  warning  'ForumModerator' is defined but never used  @typescript-eslint/no-unused-vars

traumschule avatar Jan 28 '23 10:01 traumschule

Suggest to recreate this as well: Files changed 2,718

traumschule avatar Feb 20 '23 07:02 traumschule