joystream icon indicating copy to clipboard operation
joystream copied to clipboard

Published 20 hours ago • verified publisher icon Joystream

Fix CI checks for Luxor

Open ignazio-bovo opened this issue 11 months ago • 2 comments

TLDR

Fix all CI checks for the Luxor release

Background

  • Many runtime changes have been added to Luxor runtime but not to Luxor QN, disregarding the tests/network-tests checks as a consequence
  • We have chosen to forego fixing all the CI checks in the runtime PR adding the desired features, to avoid having complex PRs
  • We now need a (possibly unique) PR updating all the network test so that the CI checks are successful

ignazio-bovo avatar Mar 20 '24 08:03 ignazio-bovo

For the runtime upgrade tests, both the integration test and the cargo unit test we need to filter out the storage state which is huge and the memory is running out on the machine when the test is running.

mnaamani avatar Mar 26 '24 20:03 mnaamani

  • Runtime upgrade integration test ➡️ It's the one using fork-off, right?
  • Runtime upgrade unit tests ➡️ is it the one with the try_runtime feature? @mnaamani

ignazio-bovo avatar Mar 28 '24 07:03 ignazio-bovo

@kdembler To sum it up: given that luxor has been released, have the CI checks been updated and fixed ?

ignazio-bovo avatar Apr 17 '24 08:04 ignazio-bovo

@ignazio-bovo Luxor upgrade is happening tomorrow, I don't think CI checks have been fixed

kdembler avatar Apr 17 '24 11:04 kdembler