joystream icon indicating copy to clipboard operation
joystream copied to clipboard

Published 20 hours ago • verified publisher icon Joystream

qn - channel agent permissions I

Open ondratra opened this issue 2 years ago • 6 comments

Fixes https://github.com/Joystream/joystream/issues/3866.

Brings QN part of changes to channel agent permissions done in https://github.com/Joystream/joystream/pull/3561. Related PRs that brought some pieces needed for this feature are https://github.com/Joystream/joystream/pull/4030 and https://github.com/Joystream/joystream/pull/3726 (updated events in QN, etc.).

In the current state, there is a missing Hydra/Warthog feature - array of enums - that is blocking this PR and is not yet overcome. Also, the code is not covered by integration tests yet.

ondratra avatar Aug 10 '22 11:08 ondratra

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Aug 25, 2022 at 8:30AM (UTC)

vercel[bot] avatar Aug 10 '22 11:08 vercel[bot]

Due to limitations described in https://github.com/Joystream/hydra/issues/507, the schema has been rewritten, and there is a ChannelAgentPermissions and CuratorAgentPermissions for each permission granted (previously, all permissions granted to the member for a given channel/curatorGroup were represented in a single record).

It is also worth noting that some seemingly redundant data were introduced in the schema. For example, channel's collaborators and collaboratorsPermissions will have similar records (collaboratorsPermissions will have some extra info). This is desired state and it will extend existing querying options without removing any.

In a perfect world, where all Hydra issues are solved, only collaboratorsPermissions would be needed, but with current nested filtering limitations and other issues, it's better to have it this way.

ondratra avatar Aug 10 '22 21:08 ondratra

Points from the previous review have all been addressed. One of the tests is failing due to some unrelated connection issue but succeeds when run locally.

ondratra avatar Aug 15 '22 00:08 ondratra

Integration tests have been added. 1 test failed due to unrelated connection issues.

ondratra avatar Aug 17 '22 18:08 ondratra

All remaining issues have been addressed.

ondratra avatar Aug 22 '22 01:08 ondratra

The recent conflict with the carthage branch has been resolved. @mnaamani please merge this PR asap before another conflict arises.

ondratra avatar Aug 23 '22 11:08 ondratra