hydra icon indicating copy to clipboard operation
hydra copied to clipboard

DatabaseManager.get() - return `null` instead of `undefined` on empty result

Open ondratra opened this issue 2 years ago • 0 comments

At the moment, DatabaseManager.get() function returns undefined when no record is found. This was in line with older TypeORM!s EntityManager that we were using until recently when we introduced a newer TypeORM version in https://github.com/Joystream/hydra/pull/491.

Let's change the return value to null to align the returning value with EntityManager. The null value is a better representation of empty results anyway, plus easier to work with in JS.

After that, we need to update the code in Joystream QN to reflect this change.

ondratra avatar Jul 20 '22 11:07 ondratra