atlas icon indicating copy to clipboard operation
atlas copied to clipboard

Published 20 hours ago • verified publisher icon Joystream

Main Atlas CRT issues

Open WRadoslaw opened this issue 1 year ago • 0 comments

  • Token value - some widgets require us to show the token value of all of the CRTs that the user has. But we don't have a clear way to do it, or I don't know much. Currently, we take the last token price received from Orion and assume that all tokens are worth that much, which is not the case. Eg. if I have 100 tokens and the 100th token is worth 100JOY on the market this doesn't mean that the 99th, 98th... and so on are worth this much because if I sell tokens to the market the price will decrease. With that, all of the token amount -> joy amount -> fiat denominations are misleading. image

  • CRT benefit entries have emoji placeholder (picker is not implemented - estimated for 5 SP)

  • CRT notifications - the Orion part of the code is not yet reviewed and notification types are not implemented in Atlas

  • Close market modal designs are not aligned with runtime logic (I have to find the issue that states it) image

  • Token Page > Holders Table - Row hover shows all user tokens - maybe it can be pushed to CRT v2

  • Token price calculation at buy/sell on the market - currently the price of the token is determined on model open action, this means that there is a possibility of another user making a sale or buy action after our first user opens the modal, but before the transaction. I assume that this will introduce the problem that the first user wants to buy X amount of token for Y JOY, but 2nd user's action in the background changed the token value and made the first user estimation in the UI no longer true. I remember that in the runtime there is some kind of way to prevent the tx if the price differs too much from the original one, but I'm not sure if it will work in this case, and if it would, then wouldn't it stop the tx if user is buying many tokens? Making the price a lot higher. 🤷‍♂️

This is all that comes to my mind at this point, it would be good if DAO could provide the state of QA from their perspective as #5636 only lists the problems in a timely ordered way and doesn't link them flow-wise.

WRadoslaw avatar Jan 29 '24 13:01 WRadoslaw