CRT DAO QA v2

[WRadoslaw]

Tasks

13/12/2023

Revenue share

• [x] Add case when holder recovers staked tokens - hide the action button

---

11/12/2023

Revenue share

• [x] Remove input from start revenue share modal https://github.com/Joystream/atlas/issues/3845#issuecomment-1840805978
• [x] Fix link to the token tab for channel https://github.com/Joystream/atlas/issues/5599
• [x] Revenue share actions on different channels https://github.com/Joystream/atlas/issues/5598
• [x] Check why there is no "starts in" state in revenue share https://github.com/Joystream/atlas/issues/5609
• [x] Check why the token is displayed as ongoing although it's upcoming https://github.com/Joystream/atlas/issues/5610

Portfolio

• [x] Add expandable revenue shares to portfolio https://github.com/Joystream/atlas/issues/3862#issuecomment-1845736747

---

Orion

• [ ] Add historical potential revenue share participants https://github.com/Joystream/atlas/issues/3848#issuecomment-1843121483

Animations

• [ ] CRT Dash Progress Widget CRT Dash Progress Widget https://github.com/Joystream/atlas/issues/3389#issuecomment-1828002918

---

Previous issue https://github.com/Joystream/atlas/issues/5483

[polikosi]

Create CRT flow:

• [x] Сhart above 100% https://github.com/Joystream/atlas/issues/3385#issuecomment-1852296381

• [ ] Make only numbers and commas/dots available https://github.com/Joystream/atlas/issues/3387#issuecomment-1852317314

Dashboard:

• [x] Add text "No holders yet" below the "top holders" icons https://github.com/Joystream/atlas/issues/3388#issuecomment-1852385681

• [x] https://github.com/Joystream/atlas/issues/3390#issuecomment-1852414293

Token Market:

• [x] Confirmation message that the market has started https://github.com/Joystream/atlas/issues/3802#issuecomment-1852504834

• [x] Change "Show sales" to "Show market" https://github.com/Joystream/atlas/issues/3805#issuecomment-1852485903

[polikosi]

bug: https://github.com/Joystream/atlas/issues/5650

Token Market:

• [x] Wrong token name and I can close the market https://github.com/Joystream/atlas/issues/3804#issuecomment-1854479021 Edit: This issue is to be resolved by https://github.com/Joystream/atlas/issues/5391

[ivanturlakov]

Retested on https://atlas-7id1hwe0w-joystream.vercel.app

Viewer

• [x] Token Page > Description - add/delete benefits feature issue

• [x] Token Page > Header Widget - short description & invite-only label display issue

• [ ] Token Page > Holders Table - Hover view all tokens - looks like not been implemented yet

[polikosi]

Holder:

• [x] Snackbar and sorting by the amount of tokens https://github.com/Joystream/atlas/issues/3835#issuecomment-1856130049 / Partially done, needs response

• [x] Percentage of tokens held by the owners and pie chart https://github.com/Joystream/atlas/issues/3842#issuecomment-1856152850

• [ ] The wrong page opens https://github.com/Joystream/atlas/issues/3856#issuecomment-1856177366

• [x] Does not match the design a bit. Add pagination. https://github.com/Joystream/atlas/issues/3841#issuecomment-1856251454

• [x] Add "Sell" button on portfolio page https://github.com/Joystream/atlas/issues/3859#issuecomment-1856290971

[polikosi]

Revenue share:

• [x] when the revenue share is active, it should be "Holders staked" and the number of participants https://github.com/Joystream/atlas/issues/3847#issuecomment-1863398693

• [x] Wrong calculation of the total and holders claimed tokens https://github.com/Joystream/atlas/issues/3848#issuecomment-1863408665

• [x] Add name of table https://github.com/Joystream/atlas/issues/3849#issuecomment-1863415967

• [x] Add the sign plus https://github.com/Joystream/atlas/issues/3851#issuecomment-1863429087

• [x] Notification, add link, change timer to relative date and time https://github.com/Joystream/atlas/issues/3852#issuecomment-1863543946 EDIT: Notifications are out of this QA scope

[ivanturlakov]

Revenue share:

YOUR_SHARE & YOUR_TOKENS values before claiming looks incorrect https://github.com/Joystream/atlas/issues/3864#issuecomment-1866429388

Locked tokens display in table(lock icon missed/alignment) https://github.com/Joystream/atlas/issues/3863#issuecomment-1866549366

[ivanturlakov]

Unchecked(still actual)

• [x] Snackbar missed https://github.com/Joystream/atlas/issues/3835#issuecomment-1917580121
• [x] Add link "See in portfolio in each stages" https://github.com/Joystream/atlas/issues/3852#issuecomment-1863543946

Both by https://github.com/Joystream/atlas/pull/5860

✅ Tested on Preview - atlas https://atlas-ljl8f2n3r-joystream.vercel.app 08.02 👍

[ivanturlakov]

Claim/Unlock

Before Claim - Can we Calculate Your Share & You Will Receive (Portfolio & Claim Modal)?

After Claim - Calculate Your Tokens value + add Lock Icon

Design

Edit Token Page

• No chance to delete all benefits
• Short description duplicates About section

⚠️ Portfolio > Sell Token Modal

• When attempting to sell multiple tokens sequentially, the modal window displays Available balance of the token that was sold first

Token Dashboard, Token Revenue Share

• Change “Ended On” to “Holders Staked” for all stages

[WRadoslaw]

Token Dashboard, Token Revenue Share

• Change “Ended On” to “Holders Staked” for all stages

It's in line with the designs, so no changes. "x% holders" indicate what it means exactly

[WRadoslaw]

• Short description duplicates About section

It's metadata issue, we don't have a way to set short description.

• No chance to delete all benefits

It needs to be done on the Orion side (or is already done)

Before Claim - Can we Calculate Your Share & You Will Receive (Portfolio & Claim Modal)?

The expected payout is calculated on Orion and it is returning 0 all the time, so it needs to be fixed there.

[kdembler]

I did a bit of testing myself and found some issues. Apologies if some have been reported already!

Creating a token

• [ ] "Learn more" doesn't link anywhere

• [ ] Confusing revenue share tooltip. It seems the second part is about annual rewards, not revenue share, and contains some placeholders.

• [ ] "Learn more" in this banner doesn't link anywhere

Token dashboard

• [x] "Total revenue" shows some amount of tokens, even though this is a new channel and has not earned anything yet.

Starting a market

• [x] "Sale" button is not available. If it's "coming later" feature, we should show something that describes it, currently it feels broken.

• [ ] Both "Learn more" don't link anywhere (screenshot above)

• [ ] Terms and conditions default value contains lorem ipsum placeholder

• [x] After submitting the transaction, a modal with instructions appears but disappears immediately.

https://github.com/Joystream/atlas/assets/12646744/ae414ffa-36e8-4326-96b0-720b1a7b0537

Market

• [x] Atlas "lets me" buy 1.5 tokens, even though the CRTs amounts are represented as integers. Concept of half a CRT doesn't exist

• [ ] Terms when buying a token are a lorem ipsum placeholder

• [x] Close market modal is showing incorrect data. It claims I need to sell -10 tokens. Apart from the fact that it wants me to sell a negative amount, I have just opened a market and have not made any transactions on it, so I own all of the supply and should be able to close without issues.

• [x] State of buy modal is not reset after I make a purchase. When I want to buy a second time I'm taken directly to the summary

https://github.com/Joystream/atlas/assets/12646744/b63f2b71-3325-4dd5-a581-4d08ada4c19f

• [ ] The status of the market is not really explained anywhere. If I have 100 tokens but AMM can buy back only 10 tokens, the UI properly sets 10 when I click 100%, but it's not explained. This will be confusing to users.
• [x] The buy price estimation is incorrect in some cases. I have bought and sold 10 tokens, leaving the total supply at the initial value. However, when I try to buy 10 tokens again, the estimate cost is much higher than for first 10 tokens that I bought. UI shows 8.6K JOY, when I actually paid only 1.5K JOY:
• [ ] I have created 2 separate tokens with exact params and then started AMM for both of them with the same params. That however has resulted in slightly different AMM settings. Shouldn't that be deterministic?

AMM pricing

• [ ] I find token pricing for AMM confusing. In the UI I have set the "Starting price for token" at 1 JOY. However, the graph shows that first token would cost ~38 JOY. In the same spirit, the graph claims that at 1k supply of my token (initial supply in my case), the price would be 24.6K JOY. Then, when market is actually started, even though the token is at 1k supply, one unit costs 36.3 JOY which doesn't match any of the previous estimates.

Misc

• [ ] I'm seeing some console errors:

[WRadoslaw]

• I have created 2 separate tokens with exact params and then started AMM for both of them with the same params. That however has resulted in slightly different AMM settings. Shouldn't that be deterministic?

It uses live JOY fiat price to determine this if I remember correctly.

• I find token pricing for AMM confusing. In the UI I have set the "Starting price for token" at 1 JOY. However, the graph shows that first token would cost ~38 JOY.

Can't help you with that, I was doing this whole thing with @ignazio-bovo guidance packages/atlas/src/utils/crts.ts:3 is the function that is used to calc the value inside packages/atlas/src/components/_crt/MarketDrawer/MarketDrawerPreview.tsx:32

[kdembler]

It uses live JOY fiat price to determine this if I remember correctly.

Why would that be the case? During the AMM activation flow, the user is asked to provide the initial price, so what would we use fiat for?

[kdembler]

• [ ] I "have" $17M just by minting a new token (this is Studio token view, also portfolio)

[dmtrjsg]

Tried to start revenue share with a newly created channel, after having created tokens + minted more on AMM.

I wasn't able to:

1. 🔴 From Dashboard widget the button was not active at all -> needs to mimic the exact behaviour of button in the Revenue share tab, so clickable and summoning the dialogue, with the same validation error as in the point below
2. 🟡 From Revenue share tab after attempt to start it, got message:

Cannot start revenue share There are no assets on the channel that could be shared with holders.

Which was confusing to me as creator.

⚠️ Suggestion: reword to

• [x] There are no assets on the channel that could be shared with holders. -> `Your channel reward account must have positive JOY balance. YPP, NFT sales and DAO rewards result in channel rewards." @WRadoslaw

[dmtrjsg]

Two more cases:

• [x] 1. Tooltip on Revenue share on teh token page has reverse ratio of revenue share:

⚠️ So in the tooltip it must say Holders 20, Channel 80

• [ ] 2. When creator sets up starting price for CRT in JOY (e.g. 1 joy). The first buyer of the token must pay exact price that creator set up.

In the screenshot below one can see that price in JOY is a LOT higher (for the example of 1 JOY the first buyer sees 236 JOY for purchase of one token)

[dmtrjsg]

Full list of learn more links that need to be removed is here:

• https://github.com/Joystream/gleev/issues/30

[dmtrjsg]

Token UX and UI

1️⃣ Suggesting to update the token ticker to max of 5 letters, and not 3 based on feedback from DAO leads

2️⃣ In the success popup after creating token the tertiary link says "view token page" currently it takes to dashboard, but needs to take to token viewers "https://dev.gleev.xyz/channel/22?tab=Token

3️⃣ From the token preview page there's no way to go back to token editing without 4 extra clicks.

Suggestion add this button to the channel view token tab for channel owners:

4️⃣ The section with Token title looks different from designs,

• grey background
• extra space which is idle
• total supply moved to top but bottom element needs more spacing now

Implementation

Design

5️⃣ Add benefit button has different design in Figma

6️⃣

We have settings on marketplace page that are not yet implemented, which I suggest to hide

HIde "On Sale" option

Hide whitelist filter

[dmtrjsg]

Tokens Minting

1️⃣ Input field pre-set for Initial tokens minting should be 10,000

Also suggest to introduce limits on the input:

• Lower bound on tokens should be 10k
• Upper bound should be 1bn

AMM

1️⃣ Update price per unit to Price for first unit. Add tooltip text `Price of each next token purchased goes up. This is based on the initially minted token supply and new tokens minted. The lesser tokens are available in supply, the higher the price increase for each token purchased."

Also suggesting to add Add Average price per unit to the purchase modal which will indicate how much actually person pays

2️⃣ For some reason I have minted 10 tokens set up revenue share at 50% and have only 6 transferable tokens in the dashboard

3️⃣ Starting market UI alignment issue

[dmtrjsg]

Minting Flow

1. CRT title: Lower case -> Upper case automatically
2. Default supply: 1bn (he tried upper limit), tried to do 100bn.
3. Assurances: Custom - would be good if they could write that and not select from drop down
4. Upper limit: allows input but gives validation error. Now set at 100k
5. Annual reward: was not clear, what annual creator rewards were
6. Final screen: ratio is incorrect for Revenue share ratio - flips holders and creators
7. Max inflation selection - also fails to the point of preventing TX Confirmation (View your token page) - have an ability to open up in a new window

Dashboard Looks amazing! Loved the onboarding

1. Arrows for progress are useless
2. Tooltip for Token master is required. Or not make it clickable
3. Right click does not offer option in the new page
4. For multiple channels CRT dash resets to the first channel
5. Brandon had a question - who sets the price for CRT in $.

Editing token page

1. Video uploaded did not pick up for setting up as CRT trailer from the first go
2. Loves the dashboard for holders on the tokens preview list
3. Holders view in editing does not have actions or filters. Would be cool to have
4. After description added the stage was still token master

Starting AMM

1. Had a bug
2. Market Started Pop up, wording is unclear in all options.

For new channel

1. Empty channel placeholder screen should invite users to create token and point to studio

View channel token

• At 50% vesting, on the token it still said 10k vested.

Starting revenue share

1. Available revenue share has no CTA.
2. You need to Design Revenue share in a way that includes.
3. He would not know what close market does (its red and its unclear if its bad to close?) - @msmadeline let's make it not red.
4. Wording on Start revenue share modal is unclear. “All tokens will be shared” - needs rewording. When the balance is Zero display this in the Revenue share modal so user does not have an error. @msmadeline let's display a warning that revenue split can only be started when channel rewards balance is positive.

Buying tokens on AMM

1. Slippage tolerance was allowed to be exceeded in the interfaces.

Suggestions

1. Token master needs to be achieved without revenue split @msmadeline can you pls address this point?