atlas
atlas copied to clipboard
Create limited access Token and manage invite list
Video update of the hi-fi work for Whitelists is here ready to be watched ✅ (Video is in a new format - half of it are flows and half are components changes for developers - so you don't have to watch it all if you're not implementing it ;) ) 🎥 Loom update: https://www.loom.com/share/2b62adb850934deaa103361bb08984ee 📄 Figma changelog link: https://www.figma.com/file/OuywwClsegx2eotkii4ea4/CRT-Creator?node-id=5%3A3258&t=uzMZaOfFWjpqAKXj-4
@KubaMikolajczyk thank you Sir for putting this together, as always excellent work ⭐
Feedback points to discuss:
- Why do we need two "invite only" tags rather close to each other? I'd say one on the tab itself would be sufficient.
- Copy upd for the banner on the Whitelist tab: "Your token cannot be sent or sold to any account that is not on that list. You can always change the token access to be open for anyone in the token settings tab."
- Copy upd for the Create token flow "Add whitelisted accounts after the token is created in the token dashboard." A single line is enough imho.
- Tooltip for the fee on adding new accounts to whitelist. "In addition to processing fee, bloat bond fees for each account are included into the transaction fee and total fee depends on the number of accounts added."
- Select member modal, I think
Add Members
would be a better header. - Token holders > since we are adding quite a few with 0 balances, and there is no sorting I wonder if we want to have "Hide 0 token holders" control
- "Edit Apply Message". Button Label "Edit Info for holders" On the viewer side prob best not to show full URL but just "Learn More" hyperlink which may be also optional. If left empty should be just hidden for viewers.
++ from Discord
CRT has its own account space, which means that in order to transact with CRT tokens (AND not being a CRT owner) requires you to have a CRT account. In order to create such account you can:
- create it directly because CTR owner added you to his whitelist
- create it because CRT owner is transferring some CRT to you All other CRT pallet extrinsics require you to have a CRT account
- This generally looks good, great job 👍
- I don't think it works to put a large text based status label inside the tab like that, i.e.
invite only
added inside the tab. Looks weird, is redundant and looks messy. - I suggest you also try to clean up some of these labels:
Token holders
=>Holders
,Token Settings
=>Settings
. - Using just a lock as the primary symbol for
invite only
seems to be adequate as the primary signal besides the token symbol. I am not even sure why exactly we need to put it there, but it is at least in a sufficiently prominent position that adding the textinvite only
seems too heavy. The creator will after all know this, they issued the token and made this decision at that time, so having a tooltip as a backup explainer seems like enough. - Be aware that we don't have any native runtime feature for this
apply message
functionality, so you need to have @drillprop probably try his hand at defining a metaprotocol way to signal this using the channel owner remark extrinsic. @kdembler will be able to provide review support and backup.
Changes done ✅ All of the implemented changes from the feedback can be found in the changelog here: https://www.figma.com/file/OuywwClsegx2eotkii4ea4/CRT-Creator?node-id=670%3A98986&t=WJYR2321kbFukXql-4
There are two points though @dmtrjsg which we need to discuss:
Num 1
- Token holders > since we are adding quite a few with 0 balances, and there is no sorting I wonder if we want to have "Hide 0 token holders" control
Currently its designed in such way that the list of holders should be sorted by total amount of CRT that each member has from the highest number to the lowest.
You can notice on the image above that the one member who has 0 tokens is pushed back to the end of the list if there would be more than one member with 0 tokens they will be all presented at the end. Therefore I cannot see a valid user need to cut the end of the holders list as this won't provide any additional information.
The only thing I would double check is if we can have this list sorted this way as this button would have much sense if we cannot sort it by total CRT and those member would have to be sorted for example by date of joining (we would have to add date of joining to the table if that would be the case) - but in our designed scenario I wouldn't add the button
Num 2
- "Edit Apply Message". Button Label "Edit Info for holders" On the viewer side prob best not to show full URL but just "Learn More" hyperlink which may be also optional. If left empty should be just hidden for viewers.
I'm all about experimenting with this label to has the one that gives the most meaning to the users but we cannot name it info for holders as this is not an info for holders - this information is for non-holder members who want to apply to become holders hence the current name.
@KubaMikolajczyk sure thing:
- Re sorting by tokens, sounds good, makes sense 👍
- Re Copy for the button let's go with "Edit Applicant Note"