atlas icon indicating copy to clipboard operation
atlas copied to clipboard

Input caret color is barely visible on some backgrounds

Open drillprop opened this issue 2 years ago • 1 comments

image

Maybe we should reconsider changing the input background to a solid one? We could also change the caret color to a different one.

drillprop avatar Jun 24 '22 12:06 drillprop

One for @toiletgranny.

dmtrjsg avatar Jun 30 '22 15:06 dmtrjsg

Screenshot 2023-01-28 172524

adding carat color as #fff (white) will solve this problem, as we don't have light and dark modes right now, if we have that then, we should consider,

  • #fff for default mode
  • var(--color-background-primary) for light mode.

please assign this issue on me, I can make this changes.

iamnamananand996 avatar Jan 28 '23 12:01 iamnamananand996

I experimented with it and it looks like a quick fix would be to change caret-color to color/text/default/strong token and it would be my recommendation. I changed it in the designs here: https://www.figma.com/file/Pf31tuYpozYmpq163U2ho8/Web-components?node-id=216%3A115828&t=KYHkyAiFIcOZJIkf-4

KubaMikolajczyk avatar Feb 20 '23 14:02 KubaMikolajczyk

cc @iamnamananand996 @chrlschwb @attemka

dmtrjsg avatar Feb 20 '23 14:02 dmtrjsg

okay, what I can understand from figma design is to have caret-color: #F4F6F8, Please confirm Is that correct ?, then, I will make this change. cc - @KubaMikolajczyk

iamnamananand996 avatar Feb 20 '23 15:02 iamnamananand996