JoyOfCoding icon indicating copy to clipboard operation
JoyOfCoding copied to clipboard

Issue 208 project submissions scoring ui

Open susham opened this issue 7 years ago • 2 comments

For retrieving the student Id and Project Name, I think method I have written checks for the string CS410. I think, this should be changed. As the summer term had both CS410 and CS510.

susham avatar Aug 30 '17 16:08 susham

@DavidWhitlock

I have made changes as per the code review. Do I have to raise another pull request, to reflect my changes?

susham avatar Sep 01 '17 16:09 susham

Also, @susham, I noticed that the Travis build failed. It looks like there was a problem with the grader application. The Travis output wasn't very helpful, but when I made a local checkout of your branch, I saw these unit tests fail:

Tests run: 11, Failures: 0, Errors: 2, Skipped: 3, Time elapsed: 0.023 sec <<< FAILURE! - in edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest
parseEmptyGrade(edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest)  Time elapsed: 0.016 sec  <<< ERROR!
java.lang.NumberFormatException: empty String
	at edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest.parse(ProjectSubmissionOutputFileParserTest.java:242)
	at edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest.parseEmptyGrade(ProjectSubmissionOutputFileParserTest.java:116)

parseTotalPoints(edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest)  Time elapsed: 0.001 sec  <<< ERROR!
java.lang.NumberFormatException: empty String
	at edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest.parse(ProjectSubmissionOutputFileParserTest.java:242)
	at edu.pdx.cs410J.grader.scoring.ProjectSubmissionOutputFileParserTest.parseTotalPoints(ProjectSubmissionOutputFileParserTest.java:100)

DavidWhitlock avatar Sep 02 '17 22:09 DavidWhitlock