docker-registry-ui icon indicating copy to clipboard operation
docker-registry-ui copied to clipboard

Multi-level min branching ignored?

Open u1735067 opened this issue 1 year ago • 4 comments

Bug description

Hi, I'm unable to reproduce the CATALOG_MIN_BRANCHES=1 + CATALOG_MAX_BRANCHES=2 case described in https://github.com/Joxit/docker-registry-ui/pull/319, am I missing something?

And while writing this, I think I understand, unlike in your test (https://github.com/Joxit/docker-registry-ui/pull/319/files#diff-702e29248f45a8a8d33d76ef028e6b85147aafab11751e0e215917ccf45523f3R73), I don't have images at the docker.io/ level.

So if it's this, it's more of a feature request, could it be possible to force a first level?

Like this:

docker.io/
    docker.io/authelia/authelia
    docker.io/grafana/
        docker.io/grafana/grafana-oss
        docker.io/grafana/grafana-oss-dev

How to Reproduce

My docker-compose file

  registry-ui-joxit:
    image: docker.io/joxit/docker-registry-ui:2.5.6
    depends_on:
      - registry
    environment:
      TZ: *TZ
      SINGLE_REGISTRY: "true"
      PULL_URL: "https://..."
      NGINX_PROXY_PASS_URL: "..."
      NGINX_RESOLVER: "127.0.0.11"
      REGISTRY_TITLE: "My registry"
      DELETE_IMAGES: "true"
      SHOW_CONTENT_DIGEST: "true"
      SHOW_CATALOG_NB_TAGS: "true"
      #HISTORY_CUSTOM_LABELS: "label1,label2"
      CATALOG_DEFAULT_EXPANDED: "true"
      CATALOG_MIN_BRANCHES: "1"
      CATALOG_MAX_BRANCHES: "2"

My resulting HTML element

<docker-registry-ui
      registry-url=""
      name="My registry"
      pull-url="https://my.registry"
      show-content-digest="true"
      is-image-remove-activated="true"
      catalog-elements-limit=""
      single-registry="true"
      default-registries=""
      read-only-registries=""
      show-catalog-nb-tags="true"
      history-custom-labels=""
      use-control-cache-header=""
      taglist-order=""
      catalog-default-expanded="true"
      catalog-min-branches="1"
      catalog-max-branches="2"
      is-registry-secured=""
      theme=""
      theme-primary-text=""
      theme-neutral-text=""
      theme-background=""
      theme-hover-background=""
      theme-accent-text=""
      theme-header-text=""
      theme-header-background=""
      theme-footer-text=""
      theme-footer-neutra-text=""
      theme-footer-background=""
      tags-per-page=""
    >

Expected behavior

Screenshots

image

u1735067 avatar Oct 24 '23 11:10 u1735067

Hello, thank you for using my project and submitting issues :smile:

I didn't cover this use case, the repository will be expendable only when there is at least one leaf/final image. That means if you push docker.io/alpine or any root image from docker hub for example, it will give you the wanted behaviour.

I thought it was more readable like this since they are all final images except for grafana which contains two images :thinking:

Should I change this behaviour ?

Joxit avatar Nov 16 '23 08:11 Joxit

@Joxit it was confusing to me too. I though i did something wrong. Maybe adding folder, image, tag icon make it easier to understand list tile type ?

mqhamdam avatar Mar 15 '24 06:03 mqhamdam