Jovi De Croock comments

Results 173 comments of


Jovi De Croock

Null check missing in AsyncComponent.getPreviousSibling()

That doesn't seem to be part of our codebase 😅 EDIT: ah I found it, this needs to go to to the Preact CLI repo https://github.com/preactjs/preact-cli/blob/master/packages/async-loader/async.js#L6

Prerendering with lazy and suspense(Template execution failed: [object Promise])

We'll need to include something like [`preact-ssr-prepass`](https://github.com/sventschui/preact-ssr-prepass) for this to work, this can resolve these promises and load the UI.

"ReferenceError: document is not defined" - Where?

Hey, I'll move this to `preact-cli` since this seems related

Smarter building when serving

I think you're on the wrong repository, You meant to post this on [preact-cli](https://github.com/preactjs/preact-cli) I'll transfer this issue for you.

Webpack-Dev-Server uses the port of the dev server regardless of where the content was served from

I don't think that is an issue with prefresh as much as it is an issue with how the `web-dev-server`/`hot-plugin` is injected, a different port should be reflected on that...

Webpack-Dev-Server uses the port of the dev server regardless of where the content was served from

I guess a good entry point would be to check whether or not normal hot-mode works i.e. if signals reach the client and if normal `preact dev` full reload mode...

Module not found: Error: Can't resolve 'react-dom'

I'm going to transfer this issue to `preact-cli`

Module not found: Error: Can't resolve 'react-dom'

This issue will get picked up, didn't really find any time yet to look at it. Are you doing anything special in your project as in extending the config, .......

Using Styled Components with interpolated values produces mangled CSS

Hey @stefcameron This seems to be caused by not interpolating the tagged template symbols. ```js const code = ` const ClusterTableRow = styled.div\` display: flex; align-items: center; text-decoration: \${'underline'}; margin:...