journaly icon indicating copy to clipboard operation
journaly copied to clipboard

l10n: time not correct in German/French etc...

Open rickyweb opened this issue 4 years ago • 2 comments

Description

Post comments are usually labelled with how long ago they have been posted. For example:

  • 1 day ago
  • about 5 minutes ago ...

In German, they turn into:

  • 1 day vor
  • about 5 minutes vor

This shows that only the string "ago" has been translated to "vor".

Suggested solution

The string should be localized as a whole, i.e.

  • "% day ago" should turn into "vor % Tag"
  • "about % minutes ago" should turn into "vor ungefähr % Minuten"

I believe the same would apply to other languages like French: "il y a % jour", "il y a % minutes"

rickyweb avatar Jan 18 '21 22:01 rickyweb

@robin-macpherson As people have started translating in other languages in the spreadsheet, I see the "relativeTimeWord" is raising some confusion. In German, the field is yellow, in French it's translated with "il y a ...", in Brasilian Portuguese "Há...". Also I noticed that there's no string for "minute(s)", "hour(s)", "day(s)", why is that?

rickyweb avatar Feb 05 '21 21:02 rickyweb

Hi @rickyweb , thanks for raising this and the confusion in the spreadsheet! The reason for having paused on that particular word is that it looks like we'll be solving it directly within our code but we need to investigate it a little bit and then figure out how to implement it. Related is #456

I think we'll end up being able to actually contribute to our date-time library to help them add more languages once we get it figured out which would be amazing too

robin-macpherson avatar Feb 05 '21 22:02 robin-macpherson