JosiahWI

Results 57 comments of JosiahWI

The AuTest proxy_serve_stale_dns_fail failed.

The AuTest ja3_fingerprint failed. I saved the log and I think I have identified the cause as a race condition in the state machine logging.

@monkuta has made the PR against the master branch as requested.

Thank you for reporting, @leontian, those two were indeed missed. I will PR a fix.

I reproduced the failure, and @appgurueu was able to identify it as caused by the tree parameters. I created the tree with a minimum child size of 3 and a...

```cpp TEST_CASE("regression test") { typedef spatial::RTree rtree_box_t; rtree_box_t rtree; Box2 box{{-3, 0}, {3, 17}}; rtree.insert(box); rtree.insert(box); rtree.insert(box); rtree.insert(box); rtree.insert(box); }```

This could already be reviewed in its current state. The work to get the unit tests to work with the build should not block any review efforts except that reviewers...

Yes, it has been considered, and it should be quite an easy change (relative to animation for example), but I did not prioritize it for this PR because it works...

I have squashed the commits that were not fixes to recent review comments and rebased on master.