create-typescript-app icon indicating copy to clipboard operation
create-typescript-app copied to clipboard
verified publisher icon JoshuaKGoldberg

🐛 Bug: Now-unnecessary no-unsafe-assignment disable in ESLint config for test files

Open JoshuaKGoldberg opened this issue 5 months ago • 2 comments

Bug Report Checklist

  • [x] I have tried restarting my IDE and the issue persists.
  • [x] I have pulled the latest main branch of the repository.
  • [x] I have searched for related issues and found none that matched my issue.

Expected

Now that https://github.com/vitest-dev/vitest/pull/7016 is merged, created ESLint configs shouldn't need to disable any no-unsafe-* rules in test files.

Actual

https://github.com/JoshuaKGoldberg/create-typescript-app/blob/94e253e7c5922dd2818e9cf7e3540ae43ba794e8/eslint.config.js#L91C32-L91C53

Additional Info

Looks like the upstream PR was reverted for the current major version in https://github.com/vitest-dev/vitest/pull/8129:

The team decided to revert the change until the next major version.

Marking this as blocked until Vitest ~~8~~ 4.

🎁

JoshuaKGoldberg avatar Jul 04 '25 18:07 JoshuaKGoldberg

Marking this as blocked until Vitest 8.

Vitest 4?

lishaduck avatar Jul 14 '25 01:07 lishaduck

Ha, yes, 4. Thanks 😄

JoshuaKGoldberg avatar Jul 14 '25 16:07 JoshuaKGoldberg