create-typescript-app icon indicating copy to clipboard operation
create-typescript-app copied to clipboard

Published 20 hours ago • verified publisher icon JoshuaKGoldberg

🚀 Feature: a github action to track bundle size

Open dlvhdr opened this issue 1 year ago • 2 comments

Bug Report Checklist

  • [X] I have pulled the latest main branch of the repository.
  • [X] I have searched for related issues and found none that matched my issue.

Overview

A github action that comments on the PR with a diff of the current bundle size vs the one in the base. Something like https://github.com/Schniz/benchy-action?tab=readme-ov-file or bundlemon.

Additional Info

No response

dlvhdr avatar Mar 19 '24 12:03 dlvhdr

Hmm, this is an interesting idea, thanks for filing... I personally don't find much benefit from these, but I know that other folks do.

My personal leanings are to say 'no' on the grounds of this only being applicable to some TypeScript packages. But I might be wrong there - leaving open in discussion in case you / anybody wants to push back on that.

JoshuaKGoldberg avatar Mar 24 '24 12:03 JoshuaKGoldberg

Not sure either if there's a solution that fits every project. I did see https://github.com/preactjs/compressed-size-action.

Anyway I have something similar in my work repo, because we recently included fakerjs in our bundle by mistake.

dlvhdr avatar Mar 25 '24 18:03 dlvhdr

Just following up: this really is a nice thing for a lot of projects, but is too specific for create-typescript-app at the moment. I'm going to go ahead and close this out. Thanks for posting!

JoshuaKGoldberg avatar Aug 07 '24 04:08 JoshuaKGoldberg