TypeStat icon indicating copy to clipboard operation
TypeStat copied to clipboard

fix: fixes reading tsconfig and handling compilerOptions

Open rubiesonthesky opened this issue 1 year ago • 0 comments

PR Checklist

Overview

Follows https://github.com/JoshuaKGoldberg/TypeStat/pull/1534

  • Fixes reading tsconfig and handling the values.
    • This can be seen in the snapshot files, where values for compilerOptions have been changed.
  • Options from typestat.json should not disable noImplicitAny or noImplicitThis if they are enabled in tsconfig.
  • Fix reading included files by changing how ts.parseJsonConfigFileContent is setup. This can been seen in action for example in include test. While before we had include: [], now we have list of files.
  • When adding ts-expect-error comments, do not add full path to files. If there are multiple people working in the same project, absolute path will not be same for everyone.
  • createProgramConfiguration and parseRawCompilerOptions both use parseJsonConfigFileContents function. No need to duplicate this code.

rubiesonthesky avatar Apr 07 '24 17:04 rubiesonthesky