TypeStat
TypeStat copied to clipboard
fix: remove unused support for file glob from command line
PR Checklist
- [x] Addresses an existing open issue: fixes #1533
- [x] That issue was marked as
status: accepting prs - [x] Steps in CONTRIBUTING.md were taken
Overview
There seems to be undocumented code path that could potentially support giving file glob from command line. Since there is no tests for this and no documentation, it's hard to say is it working as intended currently. I think the current mindset is that these kind of settings would be in the json config file.
This change makes the code simpler to understand.
Codecov Report
Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 78.98%. Comparing base (
f6dc470) to head (d2a2d17). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| src/index.ts | 0.00% | 5 Missing :warning: |
| src/options/loadPendingOptions.ts | 0.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 78.62% 78.98% +0.35%
==========================================
Files 175 175
Lines 10957 10942 -15
Branches 1021 1027 +6
==========================================
+ Hits 8615 8642 +27
+ Misses 2338 2296 -42
Partials 4 4
| Flag | Coverage Δ | |
|---|---|---|
| mutation | 73.33% <0.00%> (+0.08%) |
:arrow_up: |
| unit | 28.66% <20.00%> (+0.28%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for feedback. :) Fixed mentioned issues.
Lint step is failing because eslint config is not found for Eslint 9. But this branch should be still using Eslint 8?!
I don't know why it tried to use Eslint 9. But main is also failing because Eslint 9 PR was automerged when it's in fact failing. :/
Eslint 9 PR was automerged when it's in fact failing.
blagh this must be because I didn't set a branch protection rule.