ubuntu-rockchip icon indicating copy to clipboard operation
ubuntu-rockchip copied to clipboard
verified publisher icon Joshua-Riek

Refactor build script for improved readability and maintainability

Open danielmerja opened this issue 11 months ago • 3 comments

  • Consolidated common logic for loading suite, flavor, and board into a single load_config function.

  • Reduced repetitive cd commands and improved error handling.

  • Streamlined partial-build checks (kernel-only, rootfs-only, etc.) for early exits.

  • Ensured original functionality remains intact while enhancing code clarity.

danielmerja avatar Jan 06 '25 01:01 danielmerja

Thanks a lot for this. I will review this pr in a few days; I'm going through some stuff in my life and need some time to sort things out.

Joshua-Riek avatar Jan 07 '25 13:01 Joshua-Riek

Thanks a lot for this. I will review this pr in a few days; I'm going through some stuff in my life and need some time to sort things out.

Thank you for your contribution. This one of my favorite projects. Please take your time 🙏

danielmerja avatar Jan 07 '25 13:01 danielmerja

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 14 days. Thank you for your contribution!

github-actions[bot] avatar Mar 17 '25 12:03 github-actions[bot]

New PR #1248 with the fix. You can close this if you want.

danielmerja avatar May 25 '25 19:05 danielmerja

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 14 days. Thank you for your contribution!

github-actions[bot] avatar Aug 25 '25 12:08 github-actions[bot]

Closed. New PR #1248 with the fix

danielmerja avatar Oct 04 '25 21:10 danielmerja