Josh van Leeuwen

Results 287 comments of Josh van Leeuwen

@yaron2 fixed

@artursouza indeed, this was a bit of a scratch pad for me to investigate further what is going on. I haven't found what it is, and haven't had time to...

@sadath-12 we also want to include an integration test for this change. I'd expect a new test added for the current _default_ behaviour also, i.e.: `tests/integration/suite/daprd/app/daprapitoken.go` ```go /* Copyright 2023...

@rabollin Please can we include adding integration tests as a requirement for the workflow API becoming stable. We currently don't so have limited test coverage.

Related: https://github.com/dapr/dapr/issues/4153

Thanks @yaron2, makes sense. I agree that we should stay clear of tying Dapr APP IDs with Service Accounts in favor of getting the ID from the kube API. A...

@ItalyPaleAle I don't think the memory consumption is a problem here as we will not be using an informer in sentry, instead we will be using a single GET request...

I'd definitely consider the app ID token to be a secret since it is basically a password- even though it def contains public information, having access to the is token...