react-juce
react-juce copied to clipboard
Made CMakeLists.txt CPM-compatible
Implemented the fix detailed in https://github.com/nick-thompson/react-juce/issues/253
In summary this PR:
- Makes it possible to include react-juce with CPM
- Makes it possible to modify
REACTJUCE_JS_LIBRARY
from client code - Makes building JUCE optional
- Makes building the example optional
- Documents all of these changes
I'll fix that linting error in a sec
@sdeleon28 , apologies for the delay on this one. In crunch time at current shop. I'll do my utmost to take a first pass over this tonight!
Any updates here? Would love to have this merged :)
I'm for it, but we had originally held off on merging this because we had come up with a different way that we wanted to structure our CMake here. In particular, I remember @JoshMarler suggesting that the root level project shouldn't add juce, that we can delegate that to whomever calls add_subdirectory(react_juce)
, and therefore we can move the juce inclusion here into the example project. I think that structure would clean things up a bit still, so I think I'd prefer that. Am I missing anything there @JoshMarler? Was there more to it?