JoshMarler
Add a .h/.cpp to push/pop warning disabling for third-party headers.
Hmm I'm less sure about this one. In particular, #145 moves our Duktape headers such that they're only referenced in EcmascriptEngine.cpp. A similar refactor will follow for ShadowView.cpp and the Yoga headers. I could imagine pushing/popping different warnings for the different projects (and potentially the same argument holds for any dependencies we may add in the future), and so I wonder if the helper file would be that practical?
The helper is certainly practical in that nobody cares to be spammed by warnings caused by third party headers!
It's certainly an implementation detail, but there's limited harm in it, and it would declutter the module. This is especially true when you'll want to integrate new engines (and whatnot).