react-juce icon indicating copy to clipboard operation
react-juce copied to clipboard

Fix Duktape's C++11 detection for MSVC.

Open jrlanglois opened this issue 4 years ago • 1 comments

Duktape does a faulty check for MSVC toolchains, specifically because MSVC has never supported the __cplusplus macro (which Duktape is using).

It would be better to define the problematic macro up front, outside of Duktape:

#define DUK_F_CPP11 (JUCE_CXX14_IS_AVAILABLE) //Note that parentheses might be needed

jrlanglois avatar Dec 11 '20 14:12 jrlanglois

:+1: cool with me! That's perhaps worth opening an issue for in the Duktape repo as well

nick-thompson avatar Dec 12 '20 21:12 nick-thompson