convert-outlook-msg-file icon indicating copy to clipboard operation
convert-outlook-msg-file copied to clipboard

Feature/html body

Open jmacdone opened this issue 1 year ago • 2 comments

I was having trouble getting this to convert the msg files released by Microsoft related to the disclosure of the Midnight Blizzard attack. So, I went down a troubleshooting rabbit hole. The core issue was overlooking HTML bodies.

  • reorganized as a package (perhaps PyPI someday?)
  • add a handler for HTML bodied messages (property tag 0x1013)
  • filtered \x00 values being returned from UNICODE.value (not sure if bug?)
  • various linting and formatting tune-ups (hopefully not too opinionated)
  • updated README to reflect changes
  • no unit tests 😳

jmacdone avatar Jul 02 '24 22:07 jmacdone

Thanks. I like the ideas.

But I can't accept changes that i can't easily review. The reorganization shows up on GitHub as large deletes and large insertions, so I can't see if anything changed.

I'd be happy to review if the reorganization is removed and left for another time.

JoshData avatar Jul 03 '24 00:07 JoshData

I did break them into individual commits so you don't have to try to evaluate the whole PR as one change. But, I respect that it's hard to approve changes without unit tests to give confidence.

I made an alternative PR #30 if this is too overwhelming.

jmacdone avatar Jul 03 '24 01:07 jmacdone